-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cc(1)'s __has_include() instead of build-system checks #1118
Open
alejandro-colomar
wants to merge
7
commits into
shadow-maint:master
Choose a base branch
from
alejandro-colomar:has_include
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use cc(1)'s __has_include() instead of build-system checks #1118
alejandro-colomar
wants to merge
7
commits into
shadow-maint:master
from
alejandro-colomar:has_include
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
has_include
branch
from
November 12, 2024 22:50
8ce4bc0
to
60583eb
Compare
alejandro-colomar
force-pushed
the
has_include
branch
from
November 13, 2024 17:36
60583eb
to
c4a55a7
Compare
alejandro-colomar
force-pushed
the
has_include
branch
4 times, most recently
from
December 6, 2024 12:00
8e2ad8c
to
36a0b6e
Compare
Queued after the release of 4.17.0. |
Signed-off-by: Alejandro Colomar <[email protected]>
…_SYS_RANDOM_H Signed-off-by: Alejandro Colomar <[email protected]>
…TY_PAM_MISC_H Signed-off-by: Alejandro Colomar <[email protected]>
…Y_OPENPAM_H Signed-off-by: Alejandro Colomar <[email protected]>
It's a widely available header. Signed-off-by: Alejandro Colomar <[email protected]>
…HAVE_SYS_CAPABILITY_H Signed-off-by: Alejandro Colomar <[email protected]>
$ grep -rE 'HAVE_(UTMP)_H' $ grep -rE 'HAVE_(TERMIO|SGTTY|SYS_IOCTL|PATHS)_H' $ grep -rE 'HAVE_(LASTLOG|RPC_KEY_PROT|ACL_LIBACL)_H' $ grep -rE 'HAVE_(ATTR_LIBATTR|ATTR_ERROR_CONTEXT)_H' $ Signed-off-by: Alejandro Colomar <[email protected]>
alejandro-colomar
force-pushed
the
has_include
branch
from
December 17, 2024 23:32
36a0b6e
to
94cbd06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All relevant compilers have had __has_include() since immemorial times (GCC since version 5, according to https://en.cppreference.com/w/c/compiler_support). It's now a C23 standard feature.
This reduces the complexity of the build system.
Revisions:
v1b
v2
v2b
v2c
v2d
v2e