feat: Add Rush Monorepo support to the Shadcn CLI #5708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated create-project to avoid passing unsupported argument to the Next.js CLI
|
@IceProgrammer15 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
…rogrammer15/feat-cli-rush-support
…eat-cli-rush-support
…eProgrammer15/shadcn-ui into iceprogrammer15/feat-cli-rush-support
…eat-cli-rush-support
…eat-cli-rush-support
|
Hey @shadcn , sorry for being a terrible contributor , if reviewing this PR and merging is not a big trouble , I would appreciate if you could consider it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #5705
Description:
This pull requests adds @microsoft/rush mono repo support to the Shadcn CLI.
Rush mono repo could be configured to use either
npm,yarnorpnpmbut it has its own way of managing dependencies(i.e
npm install,yarn addorpnpm addare not used diectly.)I updated the
getPackageManager()function to detect project is managed by Rush, and use rush cli to install dependencies.I also moved dependency installation command out of
update-dependencies.tsand intopackage-manager-commands.tswhere we can build dependency installation commands for each different package managers and execute it.I believe this will help supporting more package managers in future , for instance adding deno 2 : #5529.
Tests are added to all the new and modified utility functions.