Add AUTHENTICATION_HEADER to X::Authenticator base class

sferik · Oct 25, 2023 · dcbb6a6 · dcbb6a6
1 parent a6b6acd
commit dcbb6a6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/lib/x/authenticator.rb b/lib/x/authenticator.rb
@@ -1,8 +1,10 @@
 module X
   # Base Authenticator class
   class Authenticator
+    AUTHENTICATION_HEADER = "Authorization".freeze
+
     def header(_request)
-      {"Authorization" => ""}
+      {AUTHENTICATION_HEADER => ""}
     end
   end
 end
diff --git a/lib/x/bearer_token_authenticator.rb b/lib/x/bearer_token_authenticator.rb
@@ -10,7 +10,7 @@ def initialize(bearer_token:) # rubocop:disable Lint/MissingSuper
     end
 
     def header(_request)
-      {"Authorization" => "Bearer #{bearer_token}"}
+      {AUTHENTICATION_HEADER => "Bearer #{bearer_token}"}
     end
   end
 end
diff --git a/lib/x/oauth_authenticator.rb b/lib/x/oauth_authenticator.rb
@@ -24,7 +24,7 @@ def initialize(api_key:, api_key_secret:, access_token:, access_token_secret:) #
 
     def header(request)
       method, url, query_params = parse_request(request)
-      {"Authorization" => build_oauth_header(method, url, query_params)}
+      {AUTHENTICATION_HEADER => build_oauth_header(method, url, query_params)}
     end
 
     private

diff --git a/sig/x.rbs b/sig/x.rbs
@@ -2,16 +2,18 @@ module X
   VERSION: Gem::Version
 
   class Authenticator
+    AUTHENTICATION_HEADER: String
+
     def header: (Net::HTTPRequest? request) -> Hash[String, String]
   end
 
-  class BearerTokenAuthenticator
+  class BearerTokenAuthenticator < Authenticator
     attr_accessor bearer_token: String
     def initialize: (bearer_token: String) -> void
     def header: (Net::HTTPRequest? request) -> Hash[String, String]
   end
 
-  class OAuthAuthenticator
+  class OAuthAuthenticator < Authenticator
     OAUTH_VERSION: String
     OAUTH_SIGNATURE_METHOD: String
     OAUTH_SIGNATURE_ALGORITHM: String