Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #3 #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Issue #3 #37

wants to merge 2 commits into from

Conversation

bachtsui
Copy link

@bachtsui bachtsui commented Feb 5, 2016

This merge will fix issue #3

It's the same solution for issue #2. Using the modulo method creates a bug with the year. If you want to fix the links and make sure December 2015 is clickable, you had to go to _content and remove the one again.

@nathanallen
Copy link
Contributor

So you're saying pull request #26 also fixes issue #\3?

@bachtsui
Copy link
Author

bachtsui commented Feb 5, 2016

Yes, request #26 will solve this problem. Should I close this pull and fix my title for request #26?

@nathanallen
Copy link
Contributor

For the purposes of this simulation this is fine.

If #26 were already merged in, we could simply close #3 without a new PR.
If #26 were not already merged and the solution clobbers two birds with one code-block, by all means close 'em out all at once!

@bachtsui
Copy link
Author

bachtsui commented Feb 5, 2016

Got it, thanks for the heads up Nathan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Good To Merge - great job!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bachtsui @nathanallen