-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MallocSizeOf
for euclid
types
#541
Conversation
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
As usual my main ask is that the dependency does not introduce breaking changes in the future. If changes to MallocSizeOf are planned, then either:
I see that CI is having issues probably because the dep keyword is not supported in the old rustc version currently tested. I think that it's fine to update it to a newer compiler if it isn't something too recent. I typically use whatever is in the current rustc package in debian stable (currently 1.63) as a rule of thumb for old enough that an MRSV bump shouldn't be too disruptive. |
Changes to
It's mostly Servo and Gecko who will be consuming this. So we could fall back on this if it came to it.
Ah, I'll make it use the older form. Although I've noticed a few crates failing CI recently because |
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Alright, thanks for your understanding. |
Now that malloc_size_of is published to crates.io we are moving the trait implementations of MallocSizeOf and related traits into the crates that define the types. This will avoid the situation where depending on
malloc_size_of
pulls in a large number of dependencies.This PR adds the implementation of
MallocSizeOf
to theeuclid
crate.