in case of $? take value from shell->exit_status #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
servettonga
reviewed
Jul 10, 2024
src/signal/signal.c
Outdated
| @@ -25,8 +25,8 @@ void non_interactive_signal_handlers(void) | |||
|
|
|||
| sigemptyset(&sa_int.sa_mask); | |||
| sigemptyset(&sa_quit.sa_mask); | |||
| sigaddset(&sa_int.sa_mask, SIGINT); | |||
| sigaddset(&sa_quit.sa_mask, SIGQUIT); | |||
| sigaddset(&sa_int.sa_mask, SIGQUIT); | |||
There was a problem hiding this comment.
Is it intentional or the code base it not updated?
There was a problem hiding this comment.
it was intendant. the same signal is by default do not interrupt processing of previous signal, but it's queued. So I thought the idea is to not let SIGINT interrupt action caused by SIGQUIT
should i roll it back?
There was a problem hiding this comment.
Actually sigaddset is not needed at all since sigaction is used. I shouldn't make any difference with or without. So, you can remove them totally.
servettonga
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.