Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explanation of .spy.yaml to "Working with models" #85

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

BenAuerDev
Copy link
Contributor

@BenAuerDev BenAuerDev commented Mar 27, 2024

Good morning @SandPod ,

As I was already looking into this, I figured I'd try and add it to the documentation :)

let me know if something needs to be changed

Ben

Closes: serverpod/serverpod#2055

Copy link
Contributor

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR :)!

I have requested one change for an invalid description.

A minor addition that could be useful but not necessary is to add that if the .spy.yaml extension is used you get syntax highlighting with the Serverpod VSCode plugin.

docs/05-concepts/02-models.md Outdated Show resolved Hide resolved
- removed invalid desciption
- add information about VS Code Extension
@BenAuerDev
Copy link
Contributor Author

@Isakdl thanks for the quick feedback :)

I removed the invalid description and added info about the VS Code Extension with a link to the marketplace.

Let me know when it needs more tweaking 👍

@Isakdl
Copy link
Contributor

Isakdl commented Mar 27, 2024

Very nice! Yes one last thing before we merge could you also add the change to this file:
versioned_docs/version-1.2.0/05-concepts/02-models.md

This makes it so the change is reflected for both 1.2 and the next version.

@BenAuerDev
Copy link
Contributor Author

also done :)

Copy link
Contributor

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Isakdl Isakdl merged commit 8846c49 into serverpod:main Mar 28, 2024
1 check passed
@BenAuerDev BenAuerDev deleted the update-02-models branch March 28, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's the right naming for model and serializable classes
2 participants