Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply 1.2 documentation fixes. #72

Merged
merged 3 commits into from
Feb 13, 2024
Merged

fix: Apply 1.2 documentation fixes. #72

merged 3 commits into from
Feb 13, 2024

Conversation

SandPod
Copy link
Contributor

@SandPod SandPod commented Feb 12, 2024

Changes

  • Updates documentation to always use nullable object field relation in examples.
  • Updates the deployed 1.2 documentation version with all fixes.

Closes: serverpod/serverpod#1863

@SandPod SandPod requested a review from Isakdl February 12, 2024 16:15
Isakdl
Isakdl requested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookikg good but I think there is one small mistake in one word.

versioned_docs/version-1.2.0/01-get-started.md Outdated Show resolved Hide resolved
@SandPod SandPod requested a review from Isakdl February 13, 2024 10:39
Isakdl
Isakdl approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SandPod SandPod merged commit 45cdfcb into main Feb 13, 2024
1 check passed
@SandPod SandPod deleted the update-1.2-documentation branch August 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isakdl Isakdl Isakdl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updates to documentation around relations.
2 participants
@SandPod @Isakdl