Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info when changing aws region #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add more info when changing aws region #228

wants to merge 1 commit into from

Conversation

itsJoKr
Copy link

@itsJoKr itsJoKr commented Jan 1, 2025

Wasted an hour because I didn't see that there is aws_region field.

It might take sense to you, but to a newcomer, I think it's weird that docs are talking about changing ami_instance and never mention the aws_region field.

Isakdl
Isakdl approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isakdl Isakdl Isakdl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsJoKr @Isakdl