Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add new configuration options, add example. #197

Merged
merged 4 commits into from
Oct 30, 2024
Merged

fix: Add new configuration options, add example. #197

merged 4 commits into from
Oct 30, 2024

Conversation

hampuslavin
Copy link
Contributor

Changes

  • Adds docs for new config options
  • Adds an example for when max connections limit is hit

@hampuslavin hampuslavin force-pushed the hl_update_test_docs branch 2 times, most recently from 5539d0b to a60df65 Compare October 29, 2024 14:04
@hampuslavin hampuslavin requested a review from SandPod October 29, 2024 14:08
SandPod
SandPod reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates.

Just a couple of minor comments.

docs/06-concepts/18-testing/02-the-basics.md Outdated Show resolved Hide resolved
docs/06-concepts/18-testing/02-the-basics.md Outdated Show resolved Hide resolved
SandPod
SandPod reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last fix!

docs/06-concepts/18-testing/02-the-basics.md Outdated Show resolved Hide resolved
SandPod
SandPod approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@SandPod SandPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@hampuslavin hampuslavin merged commit fbb5bee into serverpod:main Oct 30, 2024
2 checks passed
@hampuslavin hampuslavin deleted the hl_update_test_docs branch October 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandPod SandPod SandPod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hampuslavin @SandPod