Fix asynchronous stats/browsing data retrieval #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally a dictionary because the keys were used to query the DOM by code. With the new table, feeding data is enough. Note when calculating the browsing UI data, we take advantage of the fact that children items and stats' items are sorted lists so we can safely combine them, with no need to query a data source by key.
julen
force-pushed
the
issue/62-fix-get-stats
branch
2 times, most recently
from
1d4e05d to
6fe6891
Compare
This will be useful for returning exactly the same browsing data from JSON views.
|
Did a quick check in the UI: JS errors are gone, XHR calls receive data in the proper format. Let's land it. |
julen
force-pushed
the
issue/62-fix-get-stats
branch
from
6fe6891 to
a68d671
Compare
Previously, cached data from Redis would be used as-is in views. This was the case both in the browsing view and the internal API endpoint to retrieve stats, which would be consumed by the client code directly. With the recent changes in the browsing pages, we changed the shape of the data used by the client, but we didn't adjust the internal asynchronous endpoint that retrieves updated stats when these are dirty. This commit not only fixes that inconsistency, but also enables the endpoint to return browsing-related data, not only stats. This data will be the same as the data provided in templates' context. Fixes serge-community#62.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the data format the internal API endpoint returns to match the new format we are using since the move to rendering the browsing tables in React.
In order to share the code that shapes the data, it reuses the path-based view dispatching from #73. This means now the internal endpoint doesn't only return stats, but also browsing data as used by the client. This will become very useful when implement browsing without page reloads.
The the structure stats are returned from the cache via
TreeItemhas been simplified to a list too.Fixes #62.