Skip to content

Commit

Permalink
Merge pull request #36 from YamStranger/serenity_core_to_rc.4
Browse files Browse the repository at this point in the history
Updating dependency for using last serenity core, fixing issue with Java 8 support
  • Loading branch information
YamStranger committed Feb 4, 2016
2 parents 8f6d141 + 290e137 commit c36378e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
12 changes: 8 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ ext {
if (!project.hasProperty("bintrayApiKey")) {
bintrayApiKey = ''
}
serenityCoreVersion = '1.1.24'
serenityCoreVersion = '1.1.25-rc.5'

if (!project.hasProperty("bintrayApiKey")) {
bintrayApiKey = ''
Expand Down Expand Up @@ -105,8 +105,9 @@ artifacts {
configurations.all {
resolutionStrategy {
failOnVersionConflict()
force "junit:junit:${junitVersion}"
force "org.mockito:mockito-core:${mockitoCoreVersion}"
force "junit:junit:${junitVersion}",
"org.mockito:mockito-core:${mockitoCoreVersion}",
"commons-collections:commons-collections:3.2.2"
}
}

Expand All @@ -115,11 +116,14 @@ dependencies {
compile 'commons-logging:commons-logging:1.2'

compile 'com.thoughtworks.xstream:xstream:1.4.5'
compile 'com.thoughtworks.paranamer:paranamer:2.7'

compile("org.jbehave:jbehave-core:${jbehaveCoreVersion}") {
exclude group: 'org.freemarker', module: 'freemarker'
exclude group: 'junit', module: 'junit'
exclude group: 'com.thoughtworks.xstream', module: 'xstream'
exclude group: 'commons-collections', module: 'commons-collections'
exclude group: 'com.thoughtworks.paranamer', module : 'paranamer'
}

compile('de.codecentric:jbehave-junit-runner:1.2.0') {
Expand Down Expand Up @@ -265,6 +269,6 @@ if (JavaVersion.current().isJava8Compatible()) {
}

task copyDeps(type: Copy) {
from configurations.runtime
from configurations.runtime + configurations.testCompile
into project.projectDir.path+"/lib"
}
4 changes: 2 additions & 2 deletions src/main/java/net/serenitybdd/jbehave/SerenityReporter.java
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ private boolean hasSameName(Story story, String givenStoryName) {
Map<Story, WebDriver> drivers = Maps.newConcurrentMap();

private void configureDriver(Story story) {
StepEventBus.getEventBus().setUniqueSession(systemConfiguration.getUseUniqueBrowser());
StepEventBus.getEventBus().setUniqueSession(systemConfiguration.shouldUseAUniqueBrowser());
String requestedDriver = getRequestedDriver(story.getMeta());
if (StringUtils.isNotEmpty(requestedDriver)) {
ThucydidesWebDriverSupport.initialize(requestedDriver);
Expand Down Expand Up @@ -520,7 +520,7 @@ public void scenarioMeta(Meta meta) {
if (isPendingScenario()) {
StepEventBus.getEventBus().testPending();
} else if (isSkippedScenario()) {
StepEventBus.getEventBus().testIgnored();
StepEventBus.getEventBus().testSkipped();
}

}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public void should_be_able_to_set_thucydides_properties_in_the_base_test() throw

assertThat(story.getSystemConfiguration().getBaseUrl(), is("some-base-url"));
assertThat(story.getSystemConfiguration().getElementTimeout(), is(5));
assertThat(story.getSystemConfiguration().getUseUniqueBrowser(), is(true));
assertThat(story.getSystemConfiguration().shouldUseAUniqueBrowser(), is(true));
}

@Test(expected = Throwable.class)
Expand Down

0 comments on commit c36378e

Please sign in to comment.