Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed spacing calculation error in RTL mode #475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liangbx361
Copy link

No description provided.

@kishan-dhankecha
Copy link

kishan-dhankecha commented Dec 5, 2024

Hi, @liangbx361

Can you confirm if carousel_slider_plus has this issue fixed or do I need to add your proposed solution there as well?

I think the fix I recently added (kishan-dhankecha/carousel_slider_plus/issues/7), handles this so let me know.

@liangbx361
Copy link
Author

liangbx361 commented Dec 5, 2024 via email

@kishan-dhankecha
Copy link

Could you try one more thing? My change was meant to fix the reverse property not working correctly, so maybe you set that in the option like reverse: Directionality.of(context) == TextDirection.rtl, then I guess it should work.

@liangbx361
Copy link
Author

liangbx361 commented Dec 5, 2024 via email

@kishan-dhankecha
Copy link

It is fixed in 7.0.2, so it is live. Can I get a sample code that you are using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants