Add support for 128-bit integers in flatten structs and internally tagged enums #2781
+985
−520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a pretty clean fix. @dtolnay would you take a look please? |
Mingun
force-pushed
the
integer128
branch
2 times, most recently
from
8126c2c to
8d5f1d1
Compare
(review this commit with "ignore whitespace changes" option on)
failures (5):
newtype::enum_::newtype (deserialize)
newtype::enum_::struct_ (serialize)
newtype::enum_::tuple (serialize)
newtype::struct_ (deserialize)
struct_ (deserialize)
…of internally tagged enums
Deserialization not checked because there is no sequence of tokens
that could represent test values
failures (7):
newtype::enum_::newtype (deserialize)
newtype::enum_::struct (serialize)
newtype::enum_::tuple (serialize)
newtype::i128 (serialize)
newtype::struct_ (deserialize)
newtype::u128 (serialize)
struct_ (deserialize)
failures (8):
newtype::enum_::newtype (deserialize)
newtype::enum_::struct_ (serialize)
newtype::enum_::tuple (serialize)
newtype::i128 (serialize)
newtype::newtype_struct (deserialize)
newtype::struct_ (deserialize)
newtype::u128 (serialize)
struct_ (deserialize)
`Content` size doesn't changed, because it is already big enough
(64 bytes due to `TupleVariant` and `StructVariant`).
Fixes (2):
newtype::i128 (serialize)
newtype::u128 (serialize)
failures (6):
newtype::enum_::newtype (deserialize)
newtype::enum_:;struct (deserialize)
newtype::enum_::tuple (deserialize)
newtype::newtype_struct (deserialize)
newtype::struct_ (deserialize)
struct_ (deserialize)
…y tagged enums
Fixed (6):
newtype::enum_::newtype
newtype::enum_::struct_
newtype::enum_::tuple
newtype::newtype_struct
newtype::struct_
struct_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on serde-deprecated/test#6 and currently temporary uses my fork with branch that adds necessary support for testing 128-bit integers. It is possible, however, drop the first two commits, but that will mean that 128-bit integers will not be tested. I'd prefer to merge serde-deprecated/test#6 and then update this PR to use new version of
serde_test.Closes #1682, closes #2230, closes #2576