This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Separating the dto and parsing layers #64
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvgoncalves
suggested changes
May 28, 2024
There was a problem hiding this comment.
@sami-m-g let's first discuss the intent here. Also let's link to #33 and have a discussion before making this change.
Btw this PR included commits from #63; in this case it's fine since they were needed for the "moved the rest of xml" commit, but I almost missed it. Let's make sure to communicate via the PR so the review process is smoother.
jsvgoncalves
force-pushed
the
main
branch
2 times, most recently
from
559b10d to
2be9056
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.