Issue #144: Added text about the possibility of editing an invoice parameters #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ones (needs to be checked).
…ceipt_message_*.txt`).
… as feedback email address in templates.
…ebreaks to increase readablity). TODO: To extract these (and all other hardcoded here, in `send_*` methods?) texts to template files?
…ter `is_html`).
cmutel
reviewed
Apr 8, 2024
| @@ -30,14 +30,13 @@ def send_email( | |||
| plain_text_content=message, | |||
| ) | |||
| if is_html: | |||
| # TODO | |||
| raise ValueError | |||
| message.html_content = message | |||
…s-can-be-changed-in-email
cmutel
deleted the
144-include-language-that-pdf-invoice-details-can-be-changed-in-email
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I understood the task correctly: I've added the text about the possibility of editing an invoice parameters into membership and event registration email texts. But I see a mention of PDF in the task, so probably these texts should be added to the generated pdf?
See questions about other unclear tasks (#140, #141, #142) in the messenger.
Now these emails look this way:
See also just created #149 (Refactor hard-coded email messages as template files).
Other minor tasks have done:
membership_payment_receipt_message_*.txt).DEFAULT_FROM_EMAIL, should be used as feedback email address in templates.is_html).*_urls.py).