Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphQL] List entity config & state resources #4808

Merged
merged 38 commits into from
Aug 22, 2022
Merged

[GraphQL] List entity config & state resources #4808

merged 38 commits into from
Aug 22, 2022

Conversation

jamesdphillips
Copy link
Contributor

@jamesdphillips jamesdphillips commented Jul 21, 2022 •
edited
Loading

  • Expose EntityConfig & EntityState resources through GraphQL service
  • Complication: The core/v3 package previous checked that each resource in the package had a unique RBACName(), however, since we don't want distinct names for the config & state resources this proved to be problematic. As such I've disabled the uniqueness tests for the time being. Same as: Make entity config & state available through same RBAC rule #4807
  • Add Fields() method to EntityConfig & EntityState resources so that they implement the Fielder interface; allows users to filter with field selectors.
  • I apologize in the advance for the size of the PR but as is often the case >= 70% is generated code.

@jamesdphillips jamesdphillips added the component:web-ui Sensu dashboard improvements label Jul 21, 2022
Base automatically changed from jdp/rbac-next to develop/6 July 21, 2022 17:28
@jamesdphillips
Copy link
Contributor Author

DCO bot woke up and chose violence,
must mutilate history to reconcile

@jamesdphillips
more debugging
f772529 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
more debugging
dd46780 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
more debugging
66d49a1 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
more debugging
eef64ab 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
omit debugging
34385bd 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
leverage code generator more
c956621 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
rollback metadata change.. for now
6211bd4 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
abandoned prototype
d31c3f0 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
query entity config & state
a429b35 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
move
3fcc96c 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
fix borked rebase
ca6159f 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
register the extensions
e9615cf 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
ensure we do not register more than one interface
78736a1 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
i hate
f2bee16 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
add tests
a22c754 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
make entity config & state available through the same RBAC rule
2b0238c 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
fixup fetching
ad59134 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
okay
071ce7c 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
restore gen file
d8ae7ec 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
test
29d2b40 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
handle nil err
d337552 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
gimme that store v2
589a314 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
proxy
a086b2b 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
fixes nil issue
593cf7a 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
oof
f722983 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
to corev/v2 Entity
a9a0557 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
fields()
d5727ef 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips
remove unused
5e89348 
Signed-off-by: James Phillips <[email protected]>
@jamesdphillips jamesdphillips marked this pull request as ready for review August 11, 2022 03:30
@jamesdphillips
Copy link
Contributor Author

Failing check is related to this change, however I believe this is a valid use case for replace?

@jamesdphillips jamesdphillips added this to the 6.8.0 milestone Aug 22, 2022
@echlebek echlebek self-requested a review August 22, 2022 20:30
echlebek
echlebek approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Should this be ported forward to main as well?

@jamesdphillips
Copy link
Contributor Author

Great work! Should this be ported forward to main as well?

Good callout.

Part of pull request already has been with #4807, however I'll make sure to make an issue to port over the rest. I'm hoping to major version bump to finally deprecate and remove some cruft from the schema so I've been procrastinating on pulling some changes into main.

@jamesdphillips jamesdphillips merged commit f3bc8f5 into develop/6 Aug 22, 2022
@jamesdphillips jamesdphillips deleted the jdp/entity-list-perf branch August 22, 2022 21:01
@jamesdphillips jamesdphillips mentioned this pull request Aug 22, 2022
Open
4 tasks
@jamesdphillips jamesdphillips mentioned this pull request Sep 12, 2022
Merged
c-kruse pushed a commit that referenced this pull request Sep 29, 2022
@jamesdphillips @c-kruse
[GraphQL] List entity config & state resources (#4808)
6b920fe 
* Expose `EntityConfig` & `EntityState` resources through GraphQL service
* Add `Fields()` method to `EntityConfig` & `EntityState` resources so that they implement the `Fielder` interface; allows users to filter with field selectors.
* Complication: The core/v3 package previous checked that each resource in the package had a unique `RBACName()`, however, since we don't want distinct names for the config & state resources this proved to be problematic. As such I've disabled the uniqueness tests for the time being. (Same as: #4807)

Signed-off-by: James Phillips <[email protected]>
(cherry picked from commit f3bc8f5)
c-kruse pushed a commit that referenced this pull request Sep 30, 2022
@jamesdphillips @c-kruse
[GraphQL] List entity config & state resources (#4808)
848c59e 
* Expose `EntityConfig` & `EntityState` resources through GraphQL service
* Add `Fields()` method to `EntityConfig` & `EntityState` resources so that they implement the `Fielder` interface; allows users to filter with field selectors.
* Complication: The core/v3 package previous checked that each resource in the package had a unique `RBACName()`, however, since we don't want distinct names for the config & state resources this proved to be problematic. As such I've disabled the uniqueness tests for the time being. (Same as: #4807)

Signed-off-by: James Phillips <[email protected]>
(cherry picked from commit f3bc8f5)
c-kruse pushed a commit that referenced this pull request Oct 5, 2022
@jamesdphillips @c-kruse
[GraphQL] List entity config & state resources (#4808)
b3807f3 
* Expose `EntityConfig` & `EntityState` resources through GraphQL service
* Add `Fields()` method to `EntityConfig` & `EntityState` resources so that they implement the `Fielder` interface; allows users to filter with field selectors.
* Complication: The core/v3 package previous checked that each resource in the package had a unique `RBACName()`, however, since we don't want distinct names for the config & state resources this proved to be problematic. As such I've disabled the uniqueness tests for the time being. (Same as: #4807)

Signed-off-by: James Phillips <[email protected]>
(cherry picked from commit f3bc8f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echlebek echlebek echlebek approved these changes

Assignees
No one assigned
Labels
component:web-ui Sensu dashboard improvements
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesdphillips @echlebek