only validate check interval/cron when publish true (#3259)

Signed-off-by: Sean Porter <[email protected]>
sensu · Sep 6, 2019 · bb3c657 · bb3c657
1 parent 77c864e
commit bb3c657
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/api/core/v2/check.go b/api/core/v2/check.go
@@ -140,17 +140,19 @@ func (c *Check) Validate() error {
 	if err := ValidateName(c.Name); err != nil {
 		return errors.New("check name " + err.Error())
 	}
-	if c.Cron != "" {
-		if c.Interval > 0 {
-			return errors.New("must only specify either an interval or a cron schedule")
-		}
-
-		if _, err := cron.ParseStandard(c.Cron); err != nil {
-			return errors.New("check cron string is invalid")
-		}
-	} else {
-		if c.Interval < 1 {
-			return errors.New("check interval must be greater than or equal to 1")
+	if c.Publish {
+		if c.Cron != "" {
+			if c.Interval > 0 {
+				return errors.New("must only specify either an interval or a cron schedule")
+			}
+
+			if _, err := cron.ParseStandard(c.Cron); err != nil {
+				return errors.New("check cron string is invalid")
+			}
+		} else {
+			if c.Interval < 1 {
+				return errors.New("check interval must be greater than or equal to 1")
+			}
 		}
 	}
 

diff --git a/api/core/v2/check_test.go b/api/core/v2/check_test.go
@@ -35,6 +35,9 @@ func TestScheduleValidation(t *testing.T) {
 
 	c.Cron = "this is an invalid cron"
 	assert.Error(t, c.Validate())
+
+	c.Publish = false
+	assert.NoError(t, c.Validate())
 }
 
 func TestFixtureCheckIsValid(t *testing.T) {