Add option to specify the LVM command that chef-ruby-lvm runs

With sensu assets it's not trivial to call the entire plugin script with sudo
This allows us to call the lvm command with sudo specifically which is a lot easier and better for sudo security

CHANGELOG.md

@@ -8,6 +8,7 @@ This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachang
 ### Added
 - Add sensu go bonsai asset (@danragnar)
 - Bump bundler to 2.1
+- Allow to specify the LVM command to run
 
 ### Changed
 - appeased the cops (@majormoses)

bin/check-lv-usage.rb

@@ -72,6 +72,12 @@ class CheckLVUsage < Sensu::Plugin::Check::CLI
          description: 'Critical if PERCENT or more of logical metadata volume',
          proc: proc(&:to_i),
          default: 95
+
+  option :lvm_command,
+         short: '-m COMMAND',
+         long: '--command COMMAND',
+         description: 'Run this lvm command, e.g /bin/sudo /sbin/lvm'
+
   # Setup variables
   #
   def initialize(argv = ARGV)
@@ -81,7 +87,7 @@ def initialize(argv = ARGV)
   end
 
   def logical_volumes
-    @logical_volumes ||= LVM::LVM.new.logical_volumes.list
+    @logical_volumes ||= config.key?(:lvm_command) ? LVM::LVM.new(command: config[:lvm_command]).logical_volumes.list : LVM::LVM.new.logical_volumes.list
   end
 
   def empty_volumes_msg

bin/check-vg-usage.rb

@@ -61,6 +61,11 @@ class CheckVg < Sensu::Plugin::Check::CLI
          proc: proc(&:to_i),
          default: 95
 
+  option :lvm_command,
+         short: '-m COMMAND',
+         long: '--command COMMAND',
+         description: 'Run this lvm command, e.g /bin/sudo /sbin/lvm'
+
   # Setup variables
   #
   def initialize
@@ -72,7 +77,8 @@ def initialize
   # Get group data
   #
   def volume_groups
-    LVM::LVM.new.volume_groups.each do |line|
+    vgs = config.key?(:lvm_command) ? LVM::LVM.new(command: config[:lvm_command]).volume_groups : LVM::LVM.new.volume_groups
+    vgs.each do |line|
       begin
         next if config[:ignorevg]&.include?(line.name)
         next if config[:ignorevgre]&.match(line.name)

bin/metrics-vg-usage.rb

@@ -56,10 +56,16 @@ class VgUsageMetrics < Sensu::Plugin::Metric::CLI::Graphite
          description: 'Ignore volume group(s) matching regular expression',
          proc: proc { |a| Regexp.new(a) }
 
+  option :lvm_command,
+         short: '-m COMMAND',
+         long: '--command COMMAND',
+         description: 'Run this lvm command, e.g /bin/sudo /sbin/lvm'
+
   # Get group data
   #
   def volume_groups
-    LVM::LVM.new.volume_groups.each do |line|
+    vgs = config.key?(:lvm_command) ? LVM::LVM.new(command: config[:lvm_command]).volume_groups : LVM::LVM.new.volume_groups
+    vgs.each do |line|
       begin
         next if config[:ignorevg]&.include?(line.name)
         next if config[:ignorevgre]&.match(line.name)

lib/sensu-plugins-lvm/version.rb

@@ -3,7 +3,7 @@
 module SensuPluginsLvm
   module Version
     MAJOR = 2
-    MINOR = 0
+    MINOR = 1
     PATCH = 0
 
     VER_STRING = [MAJOR, MINOR, PATCH].compact.join('.')