Add GotenbergAssetRuntime to avoid passing Builder in context
#128
Conversation
Passing builder in context is fragile, as it won't work if user uses any of Twig layout features without passing the full context. Starting with Twig 4.0, the `include` function won't pass the full context, to encourage template isolation and composition. This PR introduce a Twig Runtime, lowering the impact of this extension on the global scope, and allowing to create a time-limited "scope", during which the `gotenberg_asset` will work as expected.
There was a problem hiding this comment.
Love it thanks @smnandre . Although it means that gotenberg_asset is clearly not existing within twig "normal" runtime. Which eventually we wanted to be able to enable that function to fallback to native "asset" if not in builder context. allowing the same twig template to be used for both web AND pdf. WDYT ?
When A dedicated controller may render these files but it will make them public. An other solution could be to render them as a base64 string. |
|
I'm not immersed enough in this project to have many use cases in mind... but instinctively i would have said the need to have Maybe best to have a distinct methods and user can extends their templates, blocks if they do need to render all but one image the same way. 🤷 |
Passing the builder in the Twig context is a bit fragile.
It won't work when template uses any of Twig layout features (includes, embed, macros, ...) without passing the full context.
Also, starting with Twig 4.0, the
includefunction won't pass the full context per default, with no "boolean" to do so automatically, encouraging template isolation and composition.This PR introduce a Twig Runtime, lowering the impact of the Extension on the global scope, and allowing to create a time-limited "scope", during which the
gotenberg_assetwill work as expected.