Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private key : embed wallet yet to add external wallets #174

Closed
wants to merge 4 commits into from

Conversation

0xNoushad
Copy link

Pull Request Description

Related Issue

Fixes #55

Changes Made

This PR adds the following changes:

  • Introduced BaseWallet for embedded wallet functionality.
  • Added WalletManager for centralized wallet handling.
  • Updated SolanaAgentKit to use BaseWallet instead of Keypair.

Implementation Details

  • BaseWallet supports transaction signing with both secret keys and Keypairs.
  • WalletManager ensures a single wallet instance and provides Anchor-compatible wallets.

Transaction Executed by Agent

Example transaction:

N/A


## Prompt Used  

N/A


## Additional Notes  
- Embedded wallet links to user identity for scalability.  
  
## Checklist  
- [x] I have tested these changes locally.  
- [ ] I have updated the documentation.  
- [ ] I have added a transaction link.  
- [ ] I have added the prompt used to test it.  

@slimeonmyhead
Copy link

Thanks for this change, I was able to use this to get a working example using Privy walletAPI (delegated actions and server wallets).

Many tools rely on a Keypair passed into the agent kit which makes this very annoying to fully integrate this change at the moment. I think this comment makes the most sense.

@thearyanag thearyanag closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded Wallets
3 participants