Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fluxbeam Features #148

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

DogukanGun
Copy link

Add Fluxbeam Features.
This pull request was created for https://app.gib.work/bounties/12aae7aa-ee5f-4b65-84ec-49eea1a4081d in an attempt to solve a bounty #127 . Payment for the bounty is immediately sent to the contributor after merge.

@DogukanGun
Copy link
Author

@thearyanag Hi, pr is done, waiting your review. Thanks!

@thearyanag
Copy link
Member

hey @DogukanGun - can you just merge latest changes from main, and don't commit the docs

we have removed the pre-commit hook to auto-generate docs, as that was causing merge conflicts

@DogukanGun
Copy link
Author

hey @DogukanGun - can you just merge latest changes from main, and don't commit the docs

we have removed the pre-commit hook to auto-generate docs, as that was causing merge conflicts

Hi @thearyanag , the pr is now ready for review. I have made the changes according to your comment.

@thearyanag
Copy link
Member

awesome, can you also attach a SS of the agent performing the actions

@DogukanGun
Copy link
Author

awesome, can you also attach a SS of the agent performing the actions

Screenshot 2025-01-06 at 17 23 19 Hi @thearyanag , I posted the actions. Both of them failed due to insufficient SOL balance in my wallet. Screenshot 2025-01-06 at 19 22 36

@DogukanGun
Copy link
Author

Hi @thearyanag , pr is ready for review

@thearyanag
Copy link
Member

hey @DogukanGun - can you pls attached SS for successful pool creation

@adpthegreat
Copy link
Contributor

Hey whatsup @thearyanag, i'm currently working on the fluxbeam bounty, went through this PR and MOST of it is incomplete asper the bounty feature requirements listed here https://app.gib.work/bounties/12aae7aa-ee5f-4b65-84ec-49eea1a4081d , even though in the docs there are two api endpoints making it seem like thats the only thing possible to implement, i'm currently implementing the rest of the features with tests and i'll appreciate if you give me some time so i can make a proper PR that follows the requirements with all the complete features listed in the bounty, (will send a screenshot as proof to your telegram), thank you for your time

@DogukanGun
Copy link
Author

hey @DogukanGun - can you pls attached SS for successful pool creation

Hi @thearyanag , based on my understanding, wallet creation without funding is not possible due to system constraints. Do you have any recommendation ? During my implementation, I thoroughly reviewed the documentation and found references only to swap and pool creation, which I have implemented. I did not come across any additional features to implement via API. If there are more requirements or features beyond what was documented, could you provide the specific documentation we need to use to ensure the implementation fully aligns with the bounty requirements? I will make any necessary updates accordingly.

@thearyanag
Copy link
Member

hey @DogukanGun - would it be possible to fund the wallet with a very small amount of SOL and test the implementation?

@adpthegreat
Copy link
Contributor

hey good day @thearyanag just to remind you , i have gotten most of the fluxbeam implementations down and tested they're working on mainnet , will rebase and make the PR later today, thank you for your time

@DogukanGun
Copy link
Author

hey @DogukanGun - would it be possible to fund the wallet with a very small amount of SOL and test the implementation?

Hi @thearyanag 😊 ,I ’ve funded the wallet and created a pool. Additionally, I’ve added some logs to demonstrate that the program is functioning as expected. You can see the logs in the attached screenshot.

Please let me know if you have any feedback!

Screenshot 2025-01-13 at 23 24 08

@DogukanGun
Copy link
Author

Hi @thearyanag , is there anything else I should address, or should I wait for your review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants