Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: reverseproxy-director and shared-url-struct-mutation #3486

Merged
merged 1 commit into from
Oct 15, 2024
Merged

go: reverseproxy-director and shared-url-struct-mutation #3486

merged 1 commit into from
Oct 15, 2024

Conversation

alxjsn
Copy link
Contributor

@alxjsn alxjsn commented Oct 8, 2024

Created two Go security rules based on GitHub issues golang/go#50580 and golang/go#63777. Let me know if you need anything!

0xDC0DE
0xDC0DE approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@0xDC0DE 0xDC0DE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! You could consider adding an autofix to the reverse proxy rule.

If you want to try that, let me know if you have any questions. If not, I can merge if the CI checks pass.

@alxjsn
Copy link
Contributor Author

alxjsn commented Oct 15, 2024

I don't personally need an autofix, but feel free to add it if you'd like. Thanks for reviewing!

@0xDC0DE 0xDC0DE merged commit b4eb008 into semgrep:develop Oct 15, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xDC0DE 0xDC0DE 0xDC0DE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxjsn @0xDC0DE