Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run osemgrep validate --pro #3481

Merged
merged 1 commit into from
Sep 26, 2024
Merged

run osemgrep validate --pro #3481

merged 1 commit into from
Sep 26, 2024

Conversation

aryx
Copy link
Contributor

@aryx aryx commented Sep 26, 2024

test plan:
osemgrep validate --pro .

test plan:
osemgrep validate --pro .
@aryx aryx requested review from 0xDC0DE, IagoAbal and p4p3r September 26, 2024 11:51
@aryx
Copy link
Contributor Author

aryx commented Sep 26, 2024

takes 12s (against 1m11 with pysemgrep).

@aryx
Copy link
Contributor Author

aryx commented Sep 26, 2024

(but the pysemgrep run the validation for each language dir, so it calls the registry for the metachecking rules that many times).

Copy link
Collaborator

@p4p3r p4p3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aryx aryx merged commit ecba02c into develop Sep 26, 2024
8 checks passed
@aryx aryx deleted the osemgrep_validate_pro branch September 26, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants