Remove incorrect fix for cookie-issecure-false.yaml #3236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is seemingly copied from another rule. This rule checks for missing `setSecure(true)`, but the fix replaces a `setSecure(false)` with a `setSecure(true)`. For a good autofix, this rule needs to be split into two rules: - One for a missing `setSecure` call, that adds one with the right arguments - One for a `setSecure` call with `false` that needs to be replaced with `true`. Neither will need `fix-regex`, but can be fixed with a regular `fix`.
inkz
approved these changes
Dec 25, 2023
|
@0xDC0DE do you think this update is relevant? https://github.com/semgrep/semgrep-rules/blob/develop/java/servlets/security/cookie-issecure-false.yaml#L13 |
|
No that fix seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is seemingly copied from another rule. This rule checks for missing
setSecure(true), but the fix replaces asetSecure(false)with asetSecure(true).For a good autofix, this rule needs to be split into two rules:
setSecurecall, that adds one with the right argumentssetSecurecall withfalsethat needs to be replaced withtrue.Neither will need
fix-regex, but can be fixed with a regularfix.