Add list.remove() as instance of modification within loop

Removing an item when looping causes the loop to skip over certain items.
semgrep · Nov 28, 2023 · f8c978a · f8c978a
1 parent 54e7d73
commit f8c978a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/python/lang/correctness/list-modify-iterating.py b/python/lang/correctness/list-modify-iterating.py
@@ -30,3 +30,8 @@
 for i in e:
     print(i)
     d.append(i)
+
+# ruleid:list-modify-while-iterate
+for i in e:
+    if i == 1:
+        e.remove(i)
diff --git a/python/lang/correctness/list-modify-iterating.yaml b/python/lang/correctness/list-modify-iterating.yaml
@@ -22,6 +22,10 @@ rules:
           for $ELEMENT in $LIST:
             ...
             $LIST.extend(...)
+      - pattern: |
+          for $ELEMENT in $LIST:
+            ...
+            $LIST.remove(...)
     metadata:
       category: correctness
       technology: