Skip to content

Commit

Permalink
Fix todos
Browse files Browse the repository at this point in the history
  • Loading branch information
Yosef Alsuhaibani authored and Yosef Alsuhaibani committed Aug 8, 2024
1 parent cd6cd52 commit 1a82491
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions python/django/maintainability/duplicate-path-assignment.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,32 +80,30 @@
path('path/to/view', views.other_view, {'def': 'abc'}),
]

# I would prefer duplicate-path-assignment to not match the following test cases
# to avoid giving two messages for the same issue, but could not find a way yet.
# todook: duplicate-path-assignment
# ruleid: duplicate-path-assignment-different-names, duplicate-path-assignment
# ok: duplicate-path-assignment
# ruleid: duplicate-path-assignment-different-name
urlpatterns = [
path('path/to/view', views.example_view, name="test"),
path('path/to/view', views.example_view, name="other_name"),
]

# todook: duplicate-path-assignment
# ruleid: duplicate-path-assignment-different-names, duplicate-path-assignment
# ok: duplicate-path-assignment
# ruleid: duplicate-path-assignment-different-names
urlpatterns = [
path('path/to/view', views.example_view, {'abc': 'def'}, name="test"),
path('path/to/view', views.example_view, {'abc': 'def'}, name="other_name"),
]

# todook: duplicate-path-assignment
# ruleid: duplicate-path-assignment-different-names, duplicate-path-assignment
# ok: duplicate-path-assignment
# ruleid: duplicate-path-assignment-different-names
urlpatterns = [
path('path/to/view', views.example_view, {'abc': 'def'}, name="test"),
path('path/to/other/view', views.other_view, {'abc': 'def'}, name="some_test"),
path('path/to/view', views.example_view, {'abc': 'def'}, name="other_name"),
]

# todook: duplicate-path-assignment
# ruleid: duplicate-path-assignment-different-names, duplicate-path-assignment
# ok: duplicate-path-assignment
# ruleid: duplicate-path-assignment-different-names
urlpatterns = [
path('path/to/view', views.example_view, {'abc': 'def'}, name="test123"),
path('path/to/view', views.example_view, {'def': 'abc'}, name="test456"),
Expand Down

0 comments on commit 1a82491

Please sign in to comment.