Skip to content

Commit

Permalink
chore: add symbol analysis to scan config (#343)
Browse files Browse the repository at this point in the history
As title.

- [X] I ran `make setup && make` to update the generated code after
editing a `.atd` file (TODO: have a CI check)
- [X] I made sure we're still backward compatible with old versions of
the CLI.
For example, the Semgrep backend need to still be able to *consume* data
	  generated by Semgrep 1.50.0.
See
https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
	  Note that the types related to the semgrep-core JSON output or the
	  semgrep-core RPC do not need to be backward compatible!
  • Loading branch information
brandonspark authored Feb 6, 2025
1 parent 2ec9015 commit 3c94e14
Show file tree
Hide file tree
Showing 7 changed files with 286 additions and 58 deletions.
6 changes: 5 additions & 1 deletion semgrep_output_v1.atd
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ type sca_match_kind = [
* 1st-party code (e.g., via callgraph analysis)
*)
| TransitiveUnreachable of transitive_unreachable
(* could not decide because of the engine limitations (e.g.,
(* could not decide because of the engine limitations (e.g.,
* found the use of a vulnerable library in the lockfile but
* could not find the pattern in first party code and could not
* access third-party code for further investigation
Expand Down Expand Up @@ -1226,6 +1226,10 @@ type features = {
(* normally we resolve dependencies for changed subprojects only in diff scans. This flag
* causes all subprojects to be resolved in diff scans *)
~scan_all_deps_in_diff_scan: bool;
(* Whether to collect "symbol analysis" information from the repo being scanned
See https://www.notion.so/semgrep/Semgrep-Code-Reconnaissance-Toolbox-18a3009241a880f2a439eed6b2cffe66?pvs=4
*)
~symbol_analysis: bool;
}

type triage_ignored = {
Expand Down
8 changes: 6 additions & 2 deletions semgrep_output_v1.jsonschema

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion semgrep_output_v1.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions semgrep_output_v1.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions semgrep_output_v1.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 3c94e14

Please sign in to comment.