Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gstwebrtc_app.py #41

Closed
wants to merge 2 commits into from
Closed

Conversation

xhrach06
Copy link

No description provided.

@ehfd
Copy link
Member

ehfd commented Aug 19, 2022

@danisla @JanCVanB This is @xhejtman 's student. VAAPI and NVFBC capabilities added.

@ehfd
Copy link
Member

ehfd commented Aug 19, 2022

We are going to hold the NVFBC components and make the code more comprehensible. Too many components at a time.

@ehfd
Copy link
Member

ehfd commented Aug 19, 2022

For now, review #42.

@ehfd
Copy link
Member

ehfd commented Aug 20, 2022

To be closed for now. Separate PR for NVFBC.

@danisla
Copy link
Member

danisla commented Aug 24, 2022

I would prefer this PR to be bundled with the patch to the gstreamer build that adds the nvfbch264enc and nvfbchevcenc elements.
@xhrach06 do you have the gstreamer patch ready or is it being upstreamed to the gstreamer project?

@ehfd
Copy link
Member

ehfd commented Aug 25, 2022

@danisla

@xhejtman said that this is too premature to be included, of which the patch is separate to the code. Please close for now, nvfbc will eventually be included later.

@ehfd ehfd closed this Oct 13, 2022
@GabrieleRisso
Copy link

@ehfd hello, is there any update on including nvfbc?

@ehfd
Copy link
Member

ehfd commented Jan 3, 2023

Discussed in #30.
@GabrieleRisso
Please ask @xhejtman on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants