feat: add javascriptFile property (The same as styleSheetFile property but for js files) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I would really appreciate if you could add this functionality. You don't even need to merge it, you could add it into the project by yourself. |
thederickff
changed the title
thederickff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am using
ngx-printwith Ionic+Angular, and I figured out that the<ion-icon></ion-icon>element was not being rendered, because of the missing ionicons's javascript file:<script src="https://unpkg.com/[email protected]/dist/ionicons.js"></script>Therefore, I decided to add the possibility for users being able to add scripts to the printing window page just like it is possible to do with the stylesheets. I really need these icons on my prints, but I don't know for sure yet how can I get this new version of 'ngx-print' into my project, I'll be waiting for your response.