Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Facebook Conversion API from v20 to v21 #2720

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Feb 4, 2025

This Pull request is to upgrade API version from v20 to v21 in Facebook Conversion API.
Jira ticket :- https://segment.atlassian.net/browse/STRATCONN-5408
FlagOn Gate :- https://flagon.segment.com/families/centrifuge-destinations/gates/facebook-capi-actions-canary-version

Here is the Stage Testing Document.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (52537f3) to head (4c345c9).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2720      +/-   ##
==========================================
+ Coverage   78.46%   78.50%   +0.03%     
==========================================
  Files        1036     1036              
  Lines       18771    18772       +1     
  Branches     3561     3560       -1     
==========================================
+ Hits        14729    14737       +8     
+ Misses       2844     2836       -8     
- Partials     1198     1199       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Innovative-GauravKochar Innovative-GauravKochar marked this pull request as ready for review February 4, 2025 12:20
@Innovative-GauravKochar Innovative-GauravKochar requested a review from a team as a code owner February 4, 2025 12:20
@maryamsharif maryamsharif merged commit 89d05f5 into main Feb 4, 2025
14 checks passed
@maryamsharif maryamsharif deleted the STRAT-5408 branch February 4, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants