Auto-load LivePlugins if DestinationFilters is added. (#17)

segment-integrations · Nov 26, 2024 · 0f8fcf6 · 0f8fcf6
1 parent 63417c4
commit 0f8fcf6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -0,0 +1 @@
+{}
diff --git a/Sources/AnalyticsLive/Filters/DestinationFilters.swift b/Sources/AnalyticsLive/Filters/DestinationFilters.swift
@@ -78,9 +78,13 @@ public class DestinationFilters: UtilityPlugin {
 
     public func configure(analytics: Analytics) {
         self.analytics = analytics
-
+        
         if let e = analytics.find(pluginType: LivePlugins.self) {
             e.addDependent(plugin: self)
+        } else {
+            let e = LivePlugins(fallbackFileURL: nil)
+            analytics.add(plugin: e)
+            e.addDependent(plugin: self)
         }
     }
 

diff --git a/Tests/AnalyticsLiveTests/Filters/AnalyticsFilters-Tests.swift b/Tests/AnalyticsLiveTests/Filters/AnalyticsFilters-Tests.swift
@@ -38,11 +38,15 @@ final class AnalyticsFilters_SwiftTests: XCTestCase {
 
         analytics.add(plugin: inputReader)
 
-        analytics.add(plugin: LivePlugins(fallbackFileURL: nil))
+        // Filters should add LivePlugins on its own.
+        //analytics.add(plugin: LivePlugins(fallbackFileURL: nil))
         analytics.add(plugin: filters)
 
         waitUntilStarted(analytics: analytics)
 
+        let e = analytics.find(pluginType: LivePlugins.self)
+        XCTAssertTrue(e != nil)
+
         analytics.track(name: "sampleEvent")
         RunLoop.main.run(until: Date.distantPast)
         let inputEvent: TrackEvent? = inputReader.lastEvent as? TrackEvent

diff --git a/Tests/AnalyticsLiveTests/Signals/SignalsTests.swift b/Tests/AnalyticsLiveTests/Signals/SignalsTests.swift
@@ -1,9 +1,3 @@
 import XCTest
 @testable import AnalyticsLive
 
-final class SignalsTests: XCTestCase {
-    func testDebugCheck() {
-        let debug = isAppRunningInDebug()
-        XCTAssertTrue(debug)
-    }
-}