Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue of linking 'Learn more' button to handbook (#1606) #1611

Conversation

ChamodP
Copy link
Contributor

@ChamodP ChamodP commented Jan 15, 2024

Purpose

The purpose of this PR is to fix #
not get linked to the handbook when click the 'Learn more' btn on join our team page

Goals

Approach

changed the href to the handbook URL

Screenshots

Preview Link

https://pr-{PR_NUMBER}-sef-site.surge.sh/

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Related PRs

Learning

Copy link
Member

@kumuditha-udayanga kumuditha-udayanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ChamodP, Good job!

@kumuditha-udayanga kumuditha-udayanga merged commit 1722fc8 into sef-global:master Jan 15, 2024
1 check passed
@YoshithaRathnayake
Copy link
Member

Thank you @ChamodP, Good job!

@kumuditha-udayanga couldn't tell him to add a target="_blank" 😢
I'll create another issue for that then

@kumuditha-udayanga
Copy link
Member

kumuditha-udayanga commented Jan 15, 2024

Hi @YoshithaRathnayake, Yeah it's good to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants