Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the image size of Student Ambassador page #1610

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

nimeshkavindu
Copy link
Contributor

@nimeshkavindu nimeshkavindu commented Jan 13, 2024

Purpose

Reduce the image size of Student Ambassador page #1479

Goals

Reducing the image size of Student Ambassador page

Approach

Reduced the main image size of Student Ambassador page.

Screenshots

OnPaste 20240114-191307

Preview Link

https://pr-1610-sef-site.surge.sh/student-ambassador.html

Checklist

  • I have read and understood the development best practices guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Related PRs

Learning

@YoshithaRathnayake YoshithaRathnayake changed the title reduce image size of Hero image #1479 Reduce the image size of Student Ambassador page Jan 14, 2024
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @nimeshkavindu so some changes to be changed.

  1. In the Pull Request template you have to put the issue number at The purpose of this PR is to fix #IssueNumber
  2. At the goals section you have to put the goal of the PR. (Eg: Reducing the image size of Student Ambassador page)
  3. In the Approach section you have to put how you did this like the steps you have done.
  4. At the preview link section https://pr-{pr_number}-sef-site.surge.sh/ it is like this no so you have to remove this thing {pr_number} and replace the pull request number there and at the last add the folder/file name like https://pr-XXXX-sef-site.surge.sh/student-ambassador.html..
  5. At the screenshot section you have to put a screenshot taken in the preview of the change you have done (Eg: The screenshot of the reduced image with whole page)

index.html Outdated Show resolved Hide resolved
@nimeshkavindu
Copy link
Contributor Author

Hi, @nimeshkavindu so some changes to be changed.

  1. In the Pull Request template you have to put the issue number at The purpose of this PR is to fix #IssueNumber
  2. At the goals section you have to put the goal of the PR. (Eg: Reducing the image size of Student Ambassador page)
  3. In the Approach section you have to put how you did this like the steps you have done.
  4. At the preview link section https://pr-{pr_number}-sef-site.surge.sh/ it is like this no so you have to remove this thing {pr_number} and replace the pull request number there and at the last add the folder/file name like https://pr-XXXX-sef-site.surge.sh/student-ambassador.html..
  5. At the screenshot section you have to put a screenshot taken in the preview of the change you have done (Eg: The screenshot of the reduced image with whole page)

Done.

@YoshithaRathnayake
Copy link
Member

YoshithaRathnayake commented Jan 14, 2024

Hi, @nimeshkavindu so some changes to be changed.

  1. In the Pull Request template you have to put the issue number at The purpose of this PR is to fix #IssueNumber
  2. At the goals section you have to put the goal of the PR. (Eg: Reducing the image size of Student Ambassador page)
  3. In the Approach section you have to put how you did this like the steps you have done.
  4. At the preview link section https://pr-{pr_number}-sef-site.surge.sh/ it is like this no so you have to remove this thing {pr_number} and replace the pull request number there and at the last add the folder/file name like https://pr-XXXX-sef-site.surge.sh/student-ambassador.html..
  5. At the screenshot section you have to put a screenshot taken in the preview of the change you have done (Eg: The screenshot of the reduced image with whole page)

Done.

Great! @nimeshkavindu
Do this #1610 (comment)

Co-authored-by: Yoshitha Rathnayake <[email protected]>
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Thank you @nimeshkavindu

@YoshithaRathnayake YoshithaRathnayake merged commit c2121ee into sef-global:master Jan 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants