-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the image size of Student Ambassador page #1610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @nimeshkavindu so some changes to be changed.
- In the Pull Request template you have to put the issue number at
The purpose of this PR is to fix #IssueNumber
- At the goals section you have to put the goal of the PR. (Eg: Reducing the image size of Student Ambassador page)
- In the Approach section you have to put how you did this like the steps you have done.
- At the preview link section https://pr-{pr_number}-sef-site.surge.sh/ it is like this no so you have to remove this thing {pr_number} and replace the pull request number there and at the last add the folder/file name like https://pr-XXXX-sef-site.surge.sh/student-ambassador.html..
- At the screenshot section you have to put a screenshot taken in the preview of the change you have done (Eg: The screenshot of the reduced image with whole page)
Done. |
Great! @nimeshkavindu |
Co-authored-by: Yoshitha Rathnayake <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Thank you @nimeshkavindu
Purpose
Reduce the image size of Student Ambassador page #1479
Goals
Reducing the image size of Student Ambassador page
Approach
Reduced the main image size of Student Ambassador page.
Screenshots
Preview Link
https://pr-1610-sef-site.surge.sh/student-ambassador.html
Checklist
Related PRs
Learning