-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate site to Vite and Vike for SSG #160
Conversation
|
import fontkit, { Font as FontKitFont } from 'fontkit'; | ||
import * as fontkit from 'fontkit'; | ||
import type { Font as FontKitFont } from 'fontkit'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't change the behaviour of the compiled code, so a changeset is not warranted IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just something I noticed, but font-feature-settings: "kern"
is on body
now, from chakra. Seems to only make a noticeable difference in firefox 🤷 though.
Noticed that clicking the autosuggest displays a blank suggestions list. capsize.site.autosuggest.bug.mov |
|
||
import { useAppState } from '../components/AppStateContext'; | ||
import Heading from '../components/Heading'; | ||
import { precomputeValues } from '@capsizecss/core'; | ||
|
||
const css = dedent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we are using both below, maybe just remove the alias and use dedent
explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I aliased dedent
to css
so Prettier can format the tagged string: Prettier playground.
import path from 'node:path'; | ||
import process from 'node:process'; | ||
import ghpages from 'gh-pages'; | ||
import repoPkg from '../../package.json' assert { type: 'json' }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
Co-authored-by: Michael Taranto <[email protected]>
pnpm/action-setup
which displays a warning about Node.js 16