ensure relative document referencing in FedEval document #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaileshpant
requested review from
MasterSkepticista,
kta-intel,
psfoley,
rahulga1 and
teoparvanov
as code owners
ishaileshpant
changed the title
There was a problem hiding this comment.
@ishaileshpant Have we verified this in a local documentation serving?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current FedEval document source code directly refers to the TaskRunner API global URL in ReadTheDoc, this renders local hosting of document to navigate out of the local version of the doc. We should do relative referencing so that documents even when hosted locally are navigable without global context, wherever applicable.