Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge: verify b4818 #180

Closed
wants to merge 1 commit into from
Closed

do not merge: verify b4818 #180

wants to merge 1 commit into from

Conversation

hydai
Copy link
Member

@hydai hydai commented Mar 4, 2025

No description provided.

Signed-off-by: hydai <[email protected]>
Copy link
Member

juntao commented Mar 4, 2025

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.


.github/workflows/llama.yml

Potential issues

  1. Issue with Environment Variable Usage: The environment variable $NGL is used in several jobs without being defined or passed as a parameter for all matrix configurations, leading to potential runtime errors if it's not set.

  2. Inconsistent Command Syntax: In the Llama3 8B and Llama3 8B (Streaming) jobs, the input text uses different delimiters (<|begin_of_text|>, <|eot_id|>) compared to other jobs which use <start_of_turn>user <end_of_turn><start_of_turn>model. This inconsistency may cause issues if the models expect a specific format.

  3. Lack of Error Handling: There is no error handling mechanism in place for any of the commands that download files or execute wasmedge, which can lead to incomplete downloads or failed executions without proper notification.

Summary of changes

    • Plugin Version Update: Changed the plugin from wasi_nn-ggml to wasi_nn-ggml-b4818.
  • Job Matrix Modification: Updated the matrix configuration to use a specific version of the plugin, likely for verification purposes.
  • Do Not Merge Note: The patch includes a note "do not merge: verify b4818", indicating this change should not be merged until further validation.

@hydai
Copy link
Member Author

hydai commented Mar 6, 2025

Verified, closing.

@hydai hydai closed this Mar 6, 2025
@hydai hydai deleted the hydai/verify_b4818 branch March 6, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants