WIP: Entity locator map #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well this is my first approach to it. I decided to name it EntityLocator and EntityLocatorMap to avoid confusions between EUID and EGID.
I also realized I needed the map to be bidirectional in order to allow me to update it on entity submissions so once I already had this I figured having a similar interface as INeedEGID would be harder for me to implement than just allowing the entityDB to search from EGID to EntityLocator. So I decided to make the API in entitiesDB be:
EntityLocator entitiesDB.GetLocator(EGID)andEGID entitiesDB.GetEGID(EntityLocator).I have tests for this ready to be pushed, but we can merge them after we have finalize this feature.
We can discuss it over the week, I have a few questions about how I implemented a few things.