Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Id usage in TypeSafeDictionary.AddEntityToDictionary #50

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Fix Id usage in TypeSafeDictionary.AddEntityToDictionary #50

merged 1 commit into from
Jul 21, 2020

Conversation

jlreymendez
Copy link
Collaborator

Fix TypeSafeDictionary.AddEntityToDictionary was using the entityID f…rom the original group instead the target entityID

@jlreymendez
Fix TypeSafeDictionary.AddEntityToDictionary was using the entityID f…
ada6261 
…rom the original group instead the target entityID
@sebas77 sebas77 merged commit 14e26d5 into sebas77:SECS_3_0_BETA Jul 21, 2020
@sebas77
Copy link
Owner

sebas77 commented Jul 21, 2020

good catch!! I should unit test this

@sebas77
Copy link
Owner

sebas77 commented Jul 21, 2020

BTW check the unit tests repo too Svelto.ECS.Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlreymendez @sebas77