Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neural-net parameter tests #13

Merged
merged 13 commits into from
Feb 13, 2025
Merged

Add neural-net parameter tests #13

merged 13 commits into from
Feb 13, 2025

Conversation

sebapersson
Copy link
Owner

Relatively big update adding more tests for neural network parameters, addressing the parameter points in #11. Specifically, new tests include:

  • Having neural network parameters which are not estimated (Hybrid tests 18–19).
  • Specification of nominal values for layers and/or parameter arrays (Initialization tests 1–3). These tests verify that the parameter table can specify parameters for a specific layer.
  • initializationPriorType sampling for neural networks (Initialization tests 4–16). These tests confirm that initial value sampling works for glorotUniform, glorotNormal, kaimingUniform, kaimingNormal, normal, and uniform. They also verify that different layers or parameter arrays can have different initializationPriorType settings (e.g., needed because the gain for kaimingNormal depends on the activation function). For more details, see the specification.

Additionally, for all hybrid tests, the parameter file with nominal values is now specified in the parameters table. Lastly, I’ve reorganized the test_cases directory by splitting the three test types into separate directories. Everything is tested against PEtab.jl as usual.

If all this sounds good @FFroehlich and @dilpath I will merge this.

Copy link
Contributor

@FFroehlich FFroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

Copy link
Collaborator

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me too!

Is hf5 a common extension for HDF5 files? I am used to h5 or hdf5 (e.g. see https://en.wikipedia.org/wiki/Hierarchical_Data_Format )

splitting the three test types into separate directories

Looks much nicer. Should these folders be deleted?

  • 16 folders matching test_cases/{001..016}
  • 53 foldesr matching test_cases/net_{001..053}

Co-authored-by: Dilan Pathirana <[email protected]>
@sebapersson
Copy link
Owner Author

Thanks for the feedback!

Is hf5 a common extension for HDF5 files? I am used to h5 or hdf5

This is a mistake on my part, I will change to .hdf5 ending as I think it is more clear.

Looks much nicer. Should these folders be deleted?

Seems I forgot to use git rm -r :) I will fix.

@sebapersson sebapersson merged commit f7c3780 into main Feb 13, 2025
@sebapersson sebapersson deleted the net_parameters branch February 13, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants