-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add neural-net parameter tests #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me too!
Is hf5
a common extension for HDF5 files? I am used to h5
or hdf5
(e.g. see https://en.wikipedia.org/wiki/Hierarchical_Data_Format )
splitting the three test types into separate directories
Looks much nicer. Should these folders be deleted?
- 16 folders matching
test_cases/{001..016}
- 53 foldesr matching
test_cases/net_{001..053}
Co-authored-by: Dilan Pathirana <[email protected]>
Thanks for the feedback!
This is a mistake on my part, I will change to .hdf5 ending as I think it is more clear.
Seems I forgot to use |
Relatively big update adding more tests for neural network parameters, addressing the parameter points in #11. Specifically, new tests include:
initializationPriorType
sampling for neural networks (Initialization tests 4–16). These tests confirm that initial value sampling works forglorotUniform
,glorotNormal
,kaimingUniform
,kaimingNormal
,normal
, anduniform
. They also verify that different layers or parameter arrays can have differentinitializationPriorType
settings (e.g., needed because thegain
forkaimingNormal
depends on the activation function). For more details, see the specification.Additionally, for all hybrid tests, the parameter file with nominal values is now specified in the parameters table. Lastly, I’ve reorganized the
test_cases
directory by splitting the three test types into separate directories. Everything is tested against PEtab.jl as usual.If all this sounds good @FFroehlich and @dilpath I will merge this.