fix extraction of server certificate out of rustls connection #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
approved these changes
Mar 21, 2024
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Mar 25, 2024
Bumps reqwest from 0.12.0 to 0.12.1. Release notes Sourced from reqwest's releases. v0.12.1 What's Changed Fix ClientBuilder::interface() when no TLS is enabled. Fix TlsInfo::peer_certificate() being truncated with rustls. Fix panic if http2 feature disabled but TLS negotiated h2 in ALPN. Fix Display for Error to not include its source error. New Contributors @atouchet made their first contribution in seanmonstar/reqwest#2193 @mbme made their first contribution in seanmonstar/reqwest#2195 Full Changelog: seanmonstar/[email protected] Changelog Sourced from reqwest's changelog. v0.12.1 Fix ClientBuilder::interface() when no TLS is enabled. Fix TlsInfo::peer_certificate() being truncated with rustls. Fix panic if http2 feature disabled but TLS negotiated h2 in ALPN. Fix Display for Error to not include its source error. Commits e0ea15b v0.12.1 3d78fcb fix: Display for Error shouldn't include source (#2199) c535724 Fix binding interface when no TLS is used (#2200) d5adcba fix: rustls extraction of TlsInfo::peer_certificate() being truncated (#2195) 7a5df21 fix: could panic if http2 disabled but TLS negotiated h2 (#2194) d5051f9 Update version number in Readme See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
[email protected]withrustlstheTlsInfo.peer_certificate()returns only first 2 bytes of server's TLS certificate. This PR fixes extraction of the first TLS certificate out of the rustls connection.