feat: Make encoding_rs an optional feature #2175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping it as a default feature so that the default user experience isn't to be confused about the lack of
text
. It is possible thattext
(but nottext_with_charset
) exists without theencoding_rs
feature by only trying to decode the response as utf-8 in that case. However that would mean that the behaviour changes if the feature is later added since the method would start to respectContent-Type
then.Closes #1785