-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not negotiate h2 when using native-tls backend with feature native-tls-alpn
enabled
#2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxw620
force-pushed
the
patch-h2
branch
2 times, most recently
from
March 11, 2024 15:38
c41ce8e
to
2674588
Compare
I've tested this PR with the following minimum example: #[tokio::main]
async fn main() {
// tracing_subscriber::registry().with(fmt::layer()).init();
let client = reqwest::Client::builder()
.use_native_tls()
// .use_rustls_tls()
// .proxy(reqwest::Proxy::all("socks5://127.0.0.1:20023").unwrap()) // without patch from this PR, enable proxy may cause panic with error `hyper::Error(Parse(Version))`. Unknown reason.
.build()
.unwrap();
let version = client
.get("https://google.com/")
.send()
.await
.unwrap()
.version();
println!("{:?}", version); // should get HTTP/2.0 instead of HTTP/1.1
} [dependencies]
reqwest = { version = "0.11.25", features = [
# "rustls-tls",
"native-tls-alpn",
"socks",
] }
tokio = { version = "1.36.0", features = ["full"] } |
@seanmonstar Could you provide an update on this PR? Any feedback or comments on it? Thanks :D |
seanmonstar
approved these changes
Mar 22, 2024
This was referenced Mar 23, 2024
kodiakhq bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Mar 26, 2024
Bumps reqwest from 0.12.1 to 0.12.2. Release notes Sourced from reqwest's releases. v0.12.2 What's Changed Fix missing ALPN when connecting to socks5 proxy with rustls. Fix TLS version limits with rustls. Fix not detected ALPN h2 from server with native-tls. New Contributors @cxw620 made their first contribution in seanmonstar/reqwest#2165 Full Changelog: seanmonstar/[email protected] Changelog Sourced from reqwest's changelog. v0.12.2 Fix missing ALPN when connecting to socks5 proxy with rustls. Fix TLS version limits with rustls. Fix not detected ALPN h2 from server with native-tls. Commits 6768a8e v0.12.2 fff307b fix(connect): ALPN missed when using socks5 proxy with rustls backend (#2164) 04bf45f fix: tls version limit for rustls (#2203) 056f8c4 fix(connect): not negotiate h2 when using native-tls backend (#2165) See full diff in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Nutomic
pushed a commit
to Nutomic/reqwest
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: not negotiate h2 when using native-tls backend with feature native-tls-alpn enabled.