Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make string helpers available in all templates #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peteroyle
Copy link
Member

Basically I have funnelled all instances of "this.parserContext = context" through the new setParserContext(...) method, during which I "import" the StringUtils class under the alias "render" as per http://mvel.codehaus.org/Programmatic+Imports+for+2.0 . StringUtils was copied and modified from Apache Commons Lang.

@lincolnthree
Copy link
Member

Pete. One thing I'm curious about. Can we add this in a way that would allow helpers to be disabled? Say, by Veto'ing a bean?

@lincolnthree
Copy link
Member

PS. Sorry for getting back to you so late on this. We had a team meeting last week. What you have looks like very good so far.

@peteroyle
Copy link
Member Author

Hi Lincoln. I'm trying to get around to this at some stage, thanks for waiting :)

@lincolnthree
Copy link
Member

No problem. Actually I had another thought about this. I think it would be better to add this as an extra module that could be included or excluded via Maven (much like Rewrite extensions: http://github.com/ocpsoft/rewrite)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants