User range recommendations; Fixes #177 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started implementing the corresponding frontend parts.
|
Separates the construction (generate the MiniZinc model) from the evaluation.
Updating the user workload (i.e., `num_simultaneous_users`), updating the dependent constraints, and constructing the MiniZinc model for a certain workload needs to happen atomically. Otherwise, concurrent range construction jobs could interfere with each other.
joe4dev
force-pushed
the
feature/user-range-recommendations
branch
from
f3ed913 to
88405f7
Compare
|
Works for me with the latest version and also with some legacy db dumps I migrated for testing purpose. Should be ok but might need some more testing with concurrent executions (as stated in the PR tasks) |
5 tasks
* Prefer `trigger_range` now * Including adjusted test cases. These now combine vertical and horizontal scaling.
Not needed because the number of simultaneous users is only relevant when generating new recommendations. Therefore, the number of simultaneous users should not be statically assigned to an application ingredient (via the user_workload)
|
Looks ready to merge for me now |
inz
approved these changes
Dec 19, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user range support as described in #177
Maintains the existing behavior when triggering single recommendations.
Range generation now separates constructing (i.e., generating the MiniZinc model) from evaluation. See 17a99c0 for more detail.
http://localhost:3000/ingredients/:id/recommendations_completedworks consistently; check concurrent execution with multiple workersDependency: Already rebased on PR #176