Supplant the Borrow bound on keys with a new AsKey trait
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapeinosyne
force-pushed
the
key_ergonomics
branch
from
2b65501 to
a2431d8
Compare
QP-trie keys are now bound by a new public trait, `AsKey`, rather than `Borrow<[u8]>`. `AsKey` types must be borrowable both as a key slice, much like in `Borrow`, and as `&[u8]`, which is used internally for nybble operations. The trait is implemented for common `std` types, roughly matching prior coverage, and is amenable to further expansion.
tapeinosyne
force-pushed
the
key_ergonomics
branch
from
a2431d8 to
3dc4786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of the
AsKeytrait, as proposed in #13. The primary goal of this PR is to improve the ergonomics of string keys, but it might be worth considering it as a venue to explore other key types as well.A few things should be worth considering for review. Notably:
AsKeyandBreakas implemented? Should we already seek an approach that works with keys that diverge fromBorrow, such as integers and slices thereof, tuples, and so on?Before merging, there's some housekeeping to take care of: