treewide: replace assert with SEASTAR_ASSERT #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
force-pushed
the
ss_assert
branch
3 times, most recently
from
c397013 to
4afa42b
Compare
|
Force pushes: fix C++ modules with SEASTAR_ASSERT |
avikivity
reviewed
Feb 17, 2025
include/seastar/util/assert.hh
Outdated
| * under the License. | ||
| */ | ||
| /* | ||
| * Copyright (C) 2025 ScyllaDB. |
There was a problem hiding this comment.
You should put your own (or your employer's) copyright here.
avikivity
reviewed
Feb 17, 2025
include/seastar/util/assert.hh
Outdated
| __PRETTY_FUNCTION__, #x); \ | ||
| __builtin_trap(); \ | ||
| } \ | ||
| } while (0) |
There was a problem hiding this comment.
4-space indents.
Please call a [[noreturn]] function (you can add it in reactor.cc, no need for a new source file) so that we don't have to bring in <cstdio> for everyone.
There was a problem hiding this comment.
Done. I added in log.cc to keep it in the util directory.
rockwotj
force-pushed
the
ss_assert
branch
3 times, most recently
from
a67f7f6 to
977af25
Compare
This prevents the need to undefined NDEBUG in seastar source and prevents headers from conditionally excluding these checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the need to undefined NDEBUG in seastar source and
prevents headers from conditionally excluding these checks.
See discussion here: #2539