Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduling: auto-detect scheduling group key rename() method #2628

Closed

Conversation

avikivity
Copy link
Member

make_scheduling_group_key_config() is able to create a fully functional scheduling_group_key_config, apart from the rename() method. Provide for that by detecting if the type has a rename() method and if so, create a thunk for it.

This is kept optional for backward compatibility.

make_scheduling_group_key_config() is able to create a fully
functional scheduling_group_key_config, apart from the rename()
method. Provide for that by detecting if the type has a rename()
method and if so, create a thunk for it.

This is kept optional for backward compatibility.
@avikivity
Copy link
Member Author

/cc @piodul

@piodul
Copy link
Contributor

piodul commented Jan 22, 2025

Technically speaking, this change is not forwards compatible because somebody might have a scheduling group key with a rename() method but not create a "rename" thunk for it. However, I would assume the chance of this happening to be rather low.

Other than that, LGTM.

@xemul xemul closed this in 5d8f4bd Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants