io_queue: fix static member access to comply with CWG2813 #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build failure with recent Clang implementations of CWG2813, which makes accessing static members through instance expressions into discarded-value expressions. This caused nodiscard warnings when accessing static member `tokens_capacity()` through `fgs[i]`. Before: ```c++ fgs[i].tokens_capacity() // Warns: ignoring nodiscard return value ``` After: ```c++ const auto& fg = fgs[i]); // not discarded fg.tokens_capacity(); // access static member function ``` Additionally, this refactoring reduces repetition of `fgs[g_idx]` expressions throughout the code. See: - https://cplusplus.github.io/CWG/issues/2813.html - https://eel.is/c++draft/expr.ref#2 Fixes Scylla build failure with the latest Clang, as Scylla enables Seastar_UNUSED_RESULT_ERROR. Signed-off-by: Kefu Chai <[email protected]>
|
see https://github.com/scylladb/scylladb/actions/runs/12442364586/job/34740406090 for an instance of the build failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build failure with recent Clang implementations of CWG2813, which makes accessing static members through instance expressions into discarded-value expressions. This caused nodiscard warnings when accessing static member
tokens_capacity()throughfgs[i].Before:
fgs[i].tokens_capacity() // Warns: ignoring nodiscard return valueAfter:
Additionally, this refactoring reduces repetition of
fgs[g_idx]expressions throughout the code.See:
Fixes Scylla build failure with the latest Clang, as Scylla enables Seastar_UNUSED_RESULT_ERROR.