Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fair_queue: Mark entry constructor explicit #2625

Merged

Conversation

xemul
Copy link
Contributor

@xemul xemul commented Jan 20, 2025

Otherwise calling methods that accept f.q._entry passing there an integer (and capacity_t is an integer) would compile with the help of implicit temporary entry, which is very confusing.

Otherwise calling methods that accept f.q._entry passing there an
integer (and capacity_t is an integer) would compile with the help of
implicit temporary entry, which is very confusing.

Signed-off-by: Pavel Emelyanov <[email protected]>
@xemul xemul force-pushed the br-fq-entry-constructor-mark-explicit branch from 68ce20c to 83e18eb Compare January 20, 2025 10:11
@xemul xemul changed the title fair_queue: Mark constructor explicit fair_queue: Mark entry constructor explicit Jan 20, 2025
@avikivity avikivity merged commit c3f33c1 into scylladb:master Jan 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants